Role aware container names #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent work on this! Big change, so might take a couple of days before I'm able to fully review. |
* main: Add another assertion for `escape_shell_value` Add tests for `Mrsk::Utils` Fix indentation Don't report exception here too Don't report exception Add CLI tests for remaining commands that are not tested yet Minor: Properly require active_support
* main: Ask for access token Style Style config.traefik is already nil safe Update README.md Bump dev deps and consolidate platform matches Deploys mention the released service@version Accessories aren't required to publish a port Accessories may be pulled from authenticated registries Polish destination config loading Allow arbitrary docker options for traefik Fixed typos Fixed readme Rebased on main Added volume configuration in response to issue coments Modified in response to PR comments Added the additional_ports configuration
* main: Wording Remove accessory images using tags rather than labels Update readme to point to ghcr.io/mrsked/mrsk Validate that all roles have hosts Commander needn't accumulate configuration Pull latest image tag, so we can identity it Default to deploying the config version Remove unneeded Dockerfile.dind, update Readme add D-in-D dockerfile, update Readme
ncreuschling
pushed a commit
to ncreuschling/mrsk
that referenced
this pull request
Apr 12, 2023
Rollbacks stopped working after basecamp#99. We'll confirm that a container is available for the first role on the primary host before attempting to rollback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container names don't include their role (web, job, …), so there are naming collisions when the same service tries to run with different roles on the same host. See #44.
This doesn't work right now:
… as the container name would be
app-<version>for web and job.This PR solves this by adding the role to container names. The containers for the above config would be named
app-web-<version>andapp-job-<version>.It also makes changes to
--hostsand--rolesbehaviour as to how I understand it should work:--hostsfilters the hosts for the given command and setsMRKS's@specific_hosts--rolesfilters the roles for the given command and setsMRKS's@specific_rolesMRSK.hoststakes the specific hosts (or all hosts) and filters by the specific rolesMRSK.rolestakes the specific roles (or all roles) and filters by the specific hostsNote: There's no backwards compatibility. Probably best to stop and remove all running app containers, then update mrsk, then redeploy.
TODOs:
Mrsk::Commands::Accessory(nothing todo)Mrsk::Commands::AppMrsk::Commands::AuditorMrsk::Commands::Healthcheck(nothing todo)Mrsk::Commands::Prune(nothing todo)Mrsk::Commands::Registry(nothing todo)Mrsk::Commands::Traefik(nothing todo)Non-web containers shouldn't expose 3000 so traefik doesn't get confused
When testing on a remote server, I had the issue that web (puma) and job (sidekiq) would both be recognized by traefik while only the web container would respond to http requests and somehow no requests would go through. I initially thought exposing port 3000 would be the issue but it's the traefik labels. Moving them to only the web role resolves the issue.